[Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28303


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39427|review?                     |review-
               Flag|                            |




--- Comment #47 from Simon Hausmann <hausmann at webkit.org>  2009-09-27 13:26:52 PDT ---
(From update of attachment 39427)

>From what I can see this is very good, except for a tiny TransformSource
buglet:

> -void Document::setTransformSource(void* doc)
> +void Document::setTransformSource(TransformSource* source)
>  {
> -    if (doc == m_transformSource)
> -        return;
> -
> -    xmlFreeDoc((xmlDocPtr)m_transformSource);
> -    m_transformSource = doc;
> +    m_transformSource = source;
>  }

Technically this function was protected against self-assignment and isn't
anymore. One could
argue it's a bug in OwnPtr perhaps?

> +    void setTransformSource(TransformSource*);
> +    TransformSource* transformSource() const { return m_transformSource.get(); }
>  #endif

I believe the setter should take a PassOwnPtr<TransformSource>, to make it safe
and clear that ownership is passed here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.