[Webkit-unassigned] [Bug 28902] Windows DumpRenderTree should properly set the drop effect for a drag-and-drop operation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28902





--- Comment #5 from Adam Roben (aroben) <aroben at apple.com>  2009-09-27 07:42:27 PDT ---
(From update of attachment 40183)
> +            // Reset |didDragEnter| so that another drag started within the same frame works properly.
> +            //
> +            // Notice, WebView::DragEnter (i.e. webViewDropTarget->DragEnter) initializes the field
> +            // |WebView::m_dragData|, which is checked in WebView::DragOver (i.e. webViewDropTarget->DragOver).
> +            //
> +            // If |didDragEnter| == false, then |WebView::m_dragData| is uninitialized, and by
> +            // <http://trac.webkit.org/browser/trunk/WebKit/win/WebView.cpp?rev=48754#L4657>
> +            // WebView::DragOver returns the drop effect DROPEFFECT_NONE, which is incorrect.
> +            // Hence, we set |didDragEnter| = false on a mouse up to reset the DRT drag-and-drop
> +            // machinery.

I don't understand this comment. You say that the behavior of WebView::DragOver
"is incorrect". Is there a bug filed about this incorrectness? If so, it would
probably be better to reference that bug instead of the Trac link you have now.
What is the correct behavior? Maybe this will all become clear when I see the
bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.