[Webkit-unassigned] [Bug 29706] Qt: Allow excluding certain plugins from loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29706





--- Comment #2 from Marius Renn <damarvy at gmail.com>  2009-09-26 06:07:42 PDT ---
(In reply to comment #1)
> (From update of attachment 40052 [details])
> I'm sorry, this doesn't look right.
> 
> QWebPluginDatabase has a private constructor and is a singleton accessed
> through QWebSettings. It is not designed for
> sub-classing, so adding virtual functions won't work.
> 
> Why is QWebPluginInfo's setEnabled not sufficient for your use-case?

You are right of course. (Actually, the patch we are currently using locally
makes use of a "delegate" object, which allows subclassers to implement the
shouldLoadPlugin... methods. I mistakenly thought it would be easier to move
these methods into the QWebPluginDatabase class).

Anyway, the reason we require such functionality is because we have been
getting crash reports of our app crashing during launch time. We have tracked
it down to certain plugins causing the crash when they are loaded.
Unfortunately, using QWebPluginInfo's setEnabled does not help as the plugin
may have already executed code before that (for instance, the implementation of
fetchInfo() on the Mac may execute code from the plugin). Please feel free to
correct me though if I misunderstand things.

I would like to know whether the Qt team deem such functionality useful. If so,
my suggestion would be to provide a callback interface for plugin loading. An
implementation could be set using a method setPluginLoadingDelegate() on
QWebPluginInfo. Please let me know what you think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.