[Webkit-unassigned] [Bug 29764] New: mark-bug-fixed: add -o|--open switch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29764

           Summary: mark-bug-fixed: add -o|--open switch
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: eric at webkit.org, aroben at apple.com



David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40169|                            |review?
               Flag|                            |


Created an attachment (id=40169)
 --> (https://bugs.webkit.org/attachment.cgi?id=40169)
Patch v1

Reviewed by NOBODY (OOPS!).

The -o|--open switch uses the open(1) command on Mac OS X to
open the bug URL in the default web browser.  If there are
similar mechanisms on other platforms, they may be added later.

* Scripts/mark-bug-fixed:
(MarkBugFixed.__init__): Added -o|--open switch to list of parse
options.
(MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
code into main() and extracted prompting code into
_prompt_user_for_correctness().
(MarkBugFixed._open_bug_in_web_browser): Added.
(MarkBugFixed._prompt_user_for_correctness): Added.
(MarkBugFixed.main): Added logging code from
_determine_bug_id_and_svn_revision().  Added code to call
_open_bug_in_web_browser() if the switch is set.  Added code to
call _prompt_user_for_correctness() when needed.
* Scripts/modules/bugzilla.py:
(Bugzilla.short_bug_url_for_bug_id): Added.
---
 3 files changed, 51 insertions(+), 6 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.