[Webkit-unassigned] [Bug 29689] [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29689





--- Comment #3 from Zan Dobersek <zandobersek at gmail.com>  2009-09-26 04:33:58 PDT ---
(In reply to comment #2)
> (From update of attachment 40012 [details])
> > +    FcFontSet* appFontSet = FcConfigGetFonts(0, FcSetApplication);
> > +    if (appFontSet && numFonts >= 0 && appFontSet->nfont == numFonts)
> > +        return;
> 
> So, before reading the configuration this will return NULL or something? What
> if the user has a configuration already at their home?

This sees if any fonts were added or removed via CSS @font-face rule. It checks
if the number of fonts that the current config (which was created and made
default, 'current', when initializeFonts() was called for the first time)
contains the exact same number as when it was created.
Should've added a comment explaining why that part of code is there.

> Did you test if render tree dumps are matching or more closely matching the
> expected ones in Mac? =)

Ignoring all the fonts problems, I'll start creating bugs for each of the
directories that contain tests with no generated results. Patches with these
results and diff between mac's and gtk's expected results will be uploaded to
clarify things. If there are any large differences between expected results,
the generated results will not be added to the patch, a bug will be created
about the problem and the latter will be examined thoroughly to see what's
wrong.

I'm also planning to add support for pixel tests, which will bring a better
overview to changes and help out with examining rendering differences.

Regards,
Zan Dobersek

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.