[Webkit-unassigned] [Bug 29762] New: Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29762

           Summary: Web Inspector: [REGRESSION] Double Clicking Resources
                    Fails to Open in New Window
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: rik at webkit.org, yurys at chromium.org,
                    timothy at hatcher.name, aroben at apple.com,
                    pfeldman at chromium.org, joepeck at webkit.org


Steps to Reproduce:
1. Open the Inspector
2. Select the Resources Panel
3. Double click a Resource in the sidebar (a .js or .css is good)

Expected Results:
A new window should open with that resource.

Actual Results:
A blank window.

Basics:
The fix for this is actually rather simple.  "this.resource.url" was change to
"this.resource._url", some time ago and its used 3 times still in
ResourcesPanel.js.  However, InjectedScriptAccess calls _require_ a callback
function which needed to be added.

InjectedScriptAccess:
The above fix produces a new problem.  Inside
InjectedScriptAccess._installHandler the "result" after the window.open() call
is the String => "undefined".  This causes problems with JSON.parse.

> JSON.parse("undefined")
Exception: SyntaxError: Unable to parse JSON string
> JSON.parse('"undefined"')
"undefined" // string type

Where would this best be handled? Before pushing to the front end or right
inside the _installHandler before JSON.parse()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.