[Webkit-unassigned] [Bug 28703] Refactoring placeholder-related code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28703





--- Comment #31 from Darin Adler <darin at apple.com>  2009-09-25 21:01:56 PDT ---
(From update of attachment 40160)
>      // Renderer and our event handler are responsible for sanitizing values.
>      ASSERT(value == inputElement->sanitizeValue(value) || inputElement->sanitizeValue(value).isEmpty());
> -
> -    if (inputElement->isTextField())
> -        updatePlaceholderVisibility(inputElement, element);
> +    UNUSED_PARAM(inputElement);

Instead of UNUSED_PARAM you should be using ASSERT_UNUSED, which is the assert
macro that identifies an argument used only for the assertion and not in
release versions.

    ASSERT_UNUSED(inputElement, value == inputElement->sanitizeValue(value) ||
inputElement->sanitizeValue(value).isEmpty());

That's how you do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.