[Webkit-unassigned] [Bug 29729] SQLiteTransaction should use BEGIN DEFERRED instead of BEGIN to begin read-only transactions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29729


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40098|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-09-25 14:17:29 PDT ---
(From update of attachment 40098)
I think it's fine to be explicit, assuming that "BEGIN" normally means "BEGIN
DEFERRED".  You need to answer Mark's question before we can commit this
though.

Also the ordering of the comments seems a bit odd. Maybe the two comments
should just be unified into one to explain both cases?  The links seem useful
for explaining both.

r+ but please consider the comment modifications, and make sure to answer
Mark's query before any commit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.