[Webkit-unassigned] [Bug 29715] [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in Platform.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29715





--- Comment #23 from Gavin Barraclough <barraclough at apple.com>  2009-09-25 13:23:44 PDT ---
(In reply to comment #11)
> (In reply to comment #8)
> ...
> >     #if defined(thumb2) || defined(__thumb2__)
> >     #define WTF_PLATFORM_ARM_THUMB2 1
> >     #else
> >     #define WTF_PLATFORM_ARM_TRADITIONAL 1
> >     #endif
> ...
> > #if PLATFORM(ARM_TRADITIONAL) == PLATFORM(ARM_THUMB2)
> 
> Gavin, the binary operator '==' will fail if the complementer value of those
> macros are not defined.

Loki,

No, the PLATFORM macro is defined as:

#define PLATFORM(WTF_FEATURE) (defined WTF_PLATFORM_##WTF_FEATURE  &&
WTF_PLATFORM_##WTF_FEATURE)

so the complement definitions are actually redundant.  Bear in mind,
PLATFORM(X86) evaluates to false on ARM without WTF_PLATFORM_X86 being defined.
 Do you have a compiler that this is causing a problem on? - works fine on OS X
gcc.

cheers,
G.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.