[Webkit-unassigned] [Bug 29746] New: Early returns in FrameLoader::loadURL harmful for plug-ins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29746

           Summary: Early returns in FrameLoader::loadURL harmful for
                    plug-ins
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abarth at webkit.org
                CC: fishd at chromium.org


Comment #6 From Darin Fisher (:fishd, Google) 2009-09-21 00:32:42 PDT (-)
[reply] 
I think these early returns are problematic for callers of
NPN_Get/PostURLNotify that expect a callback on success _or_ failure.  By
suppressing the frame loader notifications, the NPP_URLNotify call will be
suppressed, and that may result in memory leaks in the plugin.  (Note: This is
actually only a problem for Chrome since WebKit's plugin implementation has a
bug where it always fires NPP_URLNotify before the load completes.)

I believe the correct solution to this bug is to call
FrameLoaderClient::dispatchDidFailProvisionalLoad somehow instead of just
silently failing the loadURL / loadWithDocumentLoader calls.

Note: It looks like FrameLoader::loadURL has other early returns that could
cause similar problems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.