[Webkit-unassigned] [Bug 29744] New: svn-unapply and svn-apply don't work when used outside multiple svn working directories

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29744

           Summary: svn-unapply and svn-apply don't work when used outside
                    multiple svn working directories
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: mitz at webkit.org, eric at webkit.org



David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40130|                            |review?
               Flag|                            |


Created an attachment (id=40130)
 --> (https://bugs.webkit.org/attachment.cgi?id=40130)
Patch v1

Reviewed by NOBODY (OOPS!).

Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories.  Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.

* Scripts/VCSUtils.pm:
(determineVCSRoot): Call warn() instead of die() if both isGit()
and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
to enforce the assumption about Subversion, then return
determineSVNRoot().
* Scripts/svn-apply: Switch to using isGit() and isSVN() from
VCSUtils.pm.  They both already cache their values and checking
here is redundant since determineVCSRoot() is called later.
---
 3 files changed, 41 insertions(+), 19 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.