[Webkit-unassigned] [Bug 28970] content-type parameters not taken into account when building form-data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28970


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40117|review?                     |review-
               Flag|                            |




--- Comment #11 from Timothy Hatcher <timothy at hatcher.name>  2009-09-25 10:45:47 PDT ---
(From update of attachment 40117)
Nice work! Just fix up these little things.

> +                if (val.indexOf("%") >= 0)
> +                    try {
> +                        val = decodeURIComponent(val);
> +                    } catch(e) {
> +                        errorDecoding = true;
> +                    }

This should have braces around it since it is multiline.


> +                val = val.replace(/\+/g, " ");
> +            valEscaped = val.escapeHTML();

I know "val" isn't new, but it really should have not been abbrivated in the
first place per our style guide. Same goes for valEscaped.


> +                valEscaped += " <span class=\"error-message\">" + WebInspector.UIString("(unable to decode value)") + "</span>";

I think the UIString should have ".escapeHTML()" also, sicne the localization
could use HTML special characters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.