[Webkit-unassigned] [Bug 29740] Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29740





--- Comment #3 from Darin Adler <darin at apple.com>  2009-09-25 10:40:33 PDT ---
(From update of attachment 40118)
I was about to say r=me, but Adele beat me to it.

> +void InsertParagraphSeparatorCommand::ancestorsInsideBlock(const Node* insertionNode, Element* outerBlock, Vector<Element*>& ancestors)

Functions with an out argument like this have "get" in their name in the WebKit
coding style, so this should be named getAncestorsInsideBlock.

But I just realized this is not in the coding style document. We should add
that!

This also requires an empty vector, because it appends, but does not clear the
vector. That's probably OK. I'm not sure.

r=me but please add the "get"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.