[Webkit-unassigned] [Bug 29736] fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails since r48752

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29736





--- Comment #3 from Andras Becsi <becsi.andras at stud.u-szeged.hu>  2009-09-25 08:30:33 PDT ---
(In reply to comment #2)
> (From update of attachment 40111 [details])
> Hmm, where is the code that gets affected by this? Ie, is there something that
> checks isNull() no a QString? It should be doing isEmpty or check length I'm
> guessing...

http://trac.webkit.org/changeset/48752

Previously m_codec->toUnicode(bytes, length, &m_state) always returned a
nonnull QString which was then returned. If length was 0 the string returned
was empty but not null.
r48752 changed that. It creates a null string and if length is 0 the while loop
does not run, so the returned string remains null, and here:
http://build.webkit.org/results/Qt%20Linux%20Release/r48752%20%281911%29/results.html
you can see the failure in the layout test which is caused by this.

Now I see it probably would have been better to ping ariya whith this since he
r+-sed this, but anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.