[Webkit-unassigned] [Bug 29362] Qt build error in GraphicsContextQt.cpp (qt 4.4.0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29362


Ariya Hidayat <ariya.hidayat at trolltech.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40040|review?                     |review-
               Flag|                            |




--- Comment #7 from Ariya Hidayat <ariya.hidayat at trolltech.com>  2009-09-25 07:16:30 PDT ---
(From update of attachment 40040)
The idea is good, the implementation needs some tweak.

> +        In Qt 4.4, QBrush constructor that takes QColor was added additional
> +        default parameter Qt::BrushStyle, so that WebCore::Color isn't
> +        converted as QBrush implicitly.

Actually, it's more like "In Qt 4.5, a new function QPainter::fillRect(QRect,
QColor) is introduced".
The idea is to speed up solid color fill, because we can avoid the rather
expensive construction of QBrush.

> -        p->fillRect(shadowRect, shadowColor);
> +        p->fillRect(shadowRect, QBrush(shadowColor));

And therefore the right fix should be QColor(shadowColor). Otherwise, we keep
falling back to use QBrush, thereby cancelling out the intended optimization.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.