[Webkit-unassigned] [Bug 29715] [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in Platform.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29715


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40091|review?                     |review-
               Flag|                            |




--- Comment #8 from Gavin Barraclough <barraclough at apple.com>  2009-09-24 18:03:29 PDT ---
(From update of attachment 40091)
It doesn't make a lot of sense to me to make the presence of the
traditional/thumb2 define dependent on the assembler, and this behaviour may be
confusing to any developer not expecting this.  I'd suggest something like:

/* Defines two pseudo-platforms for ARM and Thumb-2 instruction set. */
#if !defined(WTF_PLATFORM_ARM_TRADITIONAL) && !defined(WTF_PLATFORM_ARM_THUMB2)
    #if defined(thumb2) || defined(__thumb2__)
    #define WTF_PLATFORM_ARM_THUMB2 1
    #else
    #define WTF_PLATFORM_ARM_TRADITIONAL 1
    #endif
#endif // !defined(WTF_PLATFORM_ARM_TRADITIONAL) &&
!defined(WTF_PLATFORM_ARM_THUMB2)
/* Sanity Check */
#if PLATFORM(ARM_TRADITIONAL) == PLATFORM(ARM_THUMB2)
    #error "Must define *either* PLATFORM(ARM_TRADITIONAL) *or*
PLATFORM(ARM_THUMB2)."
#endif // PLATFORM(ARM_TRADITIONAL) == PLATFORM(ARM_THUMB2)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.