[Webkit-unassigned] [Bug 28938] CSS string value is not correctly serialized when it contains binary characters

Thu Sep 24 14:05:47 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28938

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39052|review?                     |review-
               Flag|                            |

--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-09-24 14:05:47 PDT ---
(From update of attachment 39052)
I think this will be much slower than the old implementation.  We should at
least use StringBuilder instead of String::append() because String::append()
will make a new buffer every time. :(

In general the change looks OK, assuming it does not cause a PLT regression.

Could we pre-allocate the length of the new string all at once instead of doing
so many mallocs?  StringBuilder will be better, but still slower than the old
replace code was I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.