[Webkit-unassigned] [Bug 29716] [GTK] re-enable some media tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29716


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40071|review?                     |review-
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2009-09-24 10:08:52 PDT ---
(From update of attachment 40071)
OK, a couple nits:

> +        [GTK] re-enable some media tests
> +        https://bugs.webkit.org/show_bug.cgi?id=29716
> +
> +        make canPlayType() return "probably" if mime-type is known
> +        and codecs string is not empty. If codecs is empty return
> +        "maybe".
> +        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
> +        (WebCore::MediaPlayerPrivate::duration):
> +

This is refering to duration, but you only touch supportsType. Maybe it was
incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I
think you want a blank line between the message and the list of files. I'll ask
that you upload a new patch just because I am lazy and want to use the commit
bot =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.