[Webkit-unassigned] [Bug 27029] [Qt] Allow custom memory allocation control in the whole JSCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 24 08:19:50 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=27029
Zoltan Horvath <zoltan at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #40066| |review?
Flag| |
Attachment #39982|0 |1
is obsolete| |
--- Comment #4 from Zoltan Horvath <zoltan at webkit.org> 2009-09-24 08:19:49 PDT ---
Created an attachment (id=40066)
--> (https://bugs.webkit.org/attachment.cgi?id=40066)
updated proposed patch
> Why does this not just blow out the stack?
It follows the implementation of the windows version:
#if PLATFORM(WIN)
static void sleep(unsigned seconds)
{
::Sleep(seconds * 1000);
}
#endif
> Is one of them in WTF? If so, then the other should use :: to make it explicit
> that it's a root namespace call.
No it isn't. I put :: in.
> Also the sleep call seems unrelated to the rest of the patch, or at least is
> not explained in the ChangeLog.
> diff likes newlines at end of files:
> +DEFINES+=USE_SYSTEM_MALLOC
> \ No newline at end of file
> (so does GCC)
Done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list