[Webkit-unassigned] [Bug 28689] Replace disabled media mute button with port-specific implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28689


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40027|review?                     |review+
               Flag|                            |




--- Comment #12 from Eric Carlson <eric.carlson at apple.com>  2009-09-24 07:42:04 PDT ---
(From update of attachment 40027)
> -    return HTMLDivElement::rendererIsNeeded(style) && parent() && parent()->renderer();
> +    return HTMLDivElement::rendererIsNeeded(style) && parent() && parent()->renderer()
> +        && document()->page()->theme()->shouldRenderMediaControlPart(style->appearance(), m_mediaElement);

I don't know if the page can ever be NULL in this situation, but it is probably
worth adding a check since RenderObject::theme() asserts it.

> -    return HTMLInputElement::rendererIsNeeded(style) && parent() && parent()->renderer();
> +    return HTMLInputElement::rendererIsNeeded(style) && parent() && parent()->renderer()
> +        && document()->page()->theme()->shouldRenderMediaControlPart(style->appearance(), m_mediaElement);

Ditto.

r=me with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.