[Webkit-unassigned] [Bug 28733] [GTK] GtkIMContext filtering interferes with DOM key events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28733





--- Comment #15 from Xan Lopez <xan.lopez at gmail.com>  2009-09-24 04:07:49 PDT ---
(In reply to comment #14)
> I reverted this patch and I'm reopening the bug, since it broke keyboard event
> handling notification to GTK+ pretty massively :/
> 
> The thing is, the changes in EditorClientGtk.cpp to not do anything on KeyDown
> make us report back to GTK+ that key_press was unhandled, *and*, EditorClient
> is never called by WebCore for KeyUp events, so that code is effectively dead
> and doing nothing, which is obviously broken.
> 
> We need to figure out this more carefully.

So, disregard the last part, EditorClient is called for KeyUp events (fuckup
with gdb :)), but the problem is that we never mark the event as handled when
finalizing a pending composition coming from keyDown. So if we can fix this I
suppose the patch would be OK, since reporting event not handled for press is
OK since we actually only insert during KeyUp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.