[Webkit-unassigned] [Bug 29004] [HTML5][Forms] simple implementation of date&time types of INPUT element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29004


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40036|                            |review?, commit-queue?
               Flag|                            |
  Attachment #39342|0                           |1
        is obsolete|                            |




--- Comment #14 from TAMURA, Kent <tkent at chromium.org>  2009-09-23 19:43:26 PDT ---
Created an attachment (id=40036)
 --> (https://bugs.webkit.org/attachment.cgi?id=40036)
Patch part 1: recognize date&time types as text fields (rev.2)

> Explicit String construction isn't needed:
> String("button")

Fixed.

> Why two lookups?

Fixed.

> Lets make a hash for these too:
> @@ const AtomicString& HTMLInputElement::formControlType() const

Done.  I used Vector.


> Default is bad with switches over enums:
>     default:

Removed the default label and expanded the rest of types.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.