[Webkit-unassigned] [Bug 29695] Unaligned data access in YARR_JIT on ARMv5 and below

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29695





--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2009-09-23 16:37:41 PDT ---
(From update of attachment 40018)
So, the code here all looks fine, but I don't think that the ARMAssembler is
really the right layer for this.  The idea of the Assembler classes is that
they provide the same interface as the machine instruction set, and that the
MacroAssembler provides a higher level set of primitives above this.  In
similar cases where an operation must be constructed using multiple machine
instructions we try to do so in the MacroAssembler.  There are a couple of
cases where this is not so, particularly where a load or branch planted over
multiple instructions must be repatched, but we've started refactoring the
relinking so we can hopefully we can also move these up to the MacroAssembler.

So I'd prefer to see the logic in baseIndexTransfer32WithUnalignedHalfWords
shift up to the MacroAssembler.  Does this sound reasonable?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.