[Webkit-unassigned] [Bug 29302] NPAPI plugin support feature on Webkit for S60 platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29302





--- Comment #11 from Norbert Leser <norbert.leser at nokia.com>  2009-09-23 15:32:59 PDT ---
Rohini, many thanks for the updates.

There is one issue with WebCore.pro:
The export macro (BLD_INF_RULES.prj_exports += ...) is currently under symbian
&& ENABLE_NETSCAPE_PLUGIN_API=1 (way down, at lines 2400ff). That is, the
header files would not be exported in case of NPAPI disabled. 

I know that there is client code for the API that doesn't check the condition
and would pickup the wrong npapi.h in that case (there is a name conflict and
we took care that the exported npapi.h gets included first). Even though with
NPAPI disabled, applications would not link, but they would at least give a
sensible error message, given that the right npapi.h was used. If the wrong
npapi.h was picked, it is almost impossible for an apps developer to trace the
problem.

Anyway, in short, to solve this issue, I suggest to move the export macro to
the beginning of WebCore.pro, into the symbian block that is not conditional to
NPAPI being enabled (line 23ff).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.