[Webkit-unassigned] [Bug 29031] [v8] speed up access to windows impl from various methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29031





--- Comment #9 from anton muhin <antonm at chromium.org>  2009-09-23 14:28:34 PDT ---
(In reply to comment #8)
> (From update of attachment 39853 [details])
> This looks great.  Much easier to understand than the last round.  One
> question:
> 
> +namespace v8 {
> +Handle<Value> GetRealNamedProperty(
> +      Handle<Object> object,
> +      Handle<String> key);
> +}
> 
> Shouldn't this be in a v8 header file?  As written, it looks like it's grabbing
> at some random symbol in V8.

You're right, Adam---I just didn't want to touch v8's header, but still have
something compilable.  And exactly for same reason I asked not to land this
patch as I want to add this function into public V8 API.

So I'll ask for another round when this lookup goes into v8.

Thanks a lot for review, Adam!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.