[Webkit-unassigned] [Bug 29653] [Qt] Qt-based browser fails to show the right language translation

Wed Sep 23 11:13:12 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29653

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39948|review?                     |review-
               Flag|                            |

--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-09-23 11:13:12 PDT ---
(From update of attachment 39948)
You are correct.  Safari 4.0.3 on my Mac (SL) returns "en-us" but FF on the
same machine returns "en-US".  It seems we need to file a bug about Mac Safari,
I wonder if the casing could be a compat concern.

Please add a test which checks this.  Ideally a simple js-only test:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

shouldBe("navigator.language", "en-US");

which I suspect we'll have to skip on Mac.

I think that such a test should run fine on all localizations of OS X/Windows?
since I assume we override the language settings in DumpRenderTree, but maybe
my assumptions are wrong.

Either way, this change needs a test of some sort or an explanation why testing
is impossible/impractical.

Otherwise looks good!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.