[Webkit-unassigned] [Bug 26994] Store non-standard HTTP headers in history

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26994


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40005|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-09-23 10:53:43 PDT ---
(From update of attachment 40005)
> +        if (it->first.find("X-") == 0)

This is not the correct way to check for a prefix. It wastefully searches the
entire string for "X-". There's a startsWith function that can be used for this
purpose. But also, should this be a case-sensitive check or case-insensitive?

Why keep the extra headers in a map instead of just in a vector of pairs? Do we
need efficient key lookup for some reason.

I don't understand the concept of this patch; why are headers the start with
"x-" different from others? I suspect this is the wrong approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.