[Webkit-unassigned] [Bug 27800] [HTML5][Forms] Part 4 of datalist&list: Move controlClip from RenderTextControlSingleLine to TextControlElements.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27800


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38718|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2009-09-23 10:26:36 PDT ---
(From update of attachment 38718)
Actually, the change looks fine to me, but the ChangeLog is really missing
explanation as to what you're doing here.  Please post a new patch with
explanation in the Changelog as to *why* you're making this change, and little
snippets next to the individual files for the tricky bits of the change.  Clear
changelogs tend to improve review speeds.

http://webkit.org/coding/contributing.html#changelogs
Talks about good ChangeLogs and even points to an example.  Strongly suggested
reading for new(-ish) contributors.

r- for the unclear ChangeLog, but in general this looks fine.  Again, would be
good to get a "yeah this looks sane" from someone who works on forms, but if
they're not answering your email (assuming you've sent one?), then there is
only so much we can do. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.