[Webkit-unassigned] [Bug 29670] Crash observed while loading plugin content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29670





--- Comment #2 from Tor Arne Vestbø <vestbo at webkit.org>  2009-09-23 03:12:15 PDT ---
(From update of attachment 39983)
Why isn't this already caught by the null-check 4 lines above the didReciveData
call?

    // We re-check here as the plugin can have been created
    if (m_pluginView) {
        if (!m_hasSentResponseToPlugin) {
            m_pluginView->didReceiveResponse(loader->response());
            // didReceiveResponse sets up a new stream to the plug-in. on a
full-page plug-in, a failure in
            // setting up this stream can cause the main document load to be
cancelled, setting m_pluginView
            // to null
            if (!m_pluginView)
                return;
            m_hasSentResponseToPlugin = true;
        }
        m_pluginView->didReceiveData(data, length);
    }

Also, for future reference:

 - Do patches based on the root of the webkit source tree, not inside WebKit
 - Follow the QtWebKit bug reporting guidlines
http://trac.webkit.org/wiki/QtWebKitContrib#ReportingBugs
   - In particular, choose the right component and add the Qt keyword
 - You can safely leave out comments like the one in this patch, that's what
the changelog/commit message is for

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.