[Webkit-unassigned] [Bug 29651] [HTML5] Add a way for an application to register as a protocol handler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29651


B. Green <brg at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39979|                            |review?
               Flag|                            |
  Attachment #39940|0                           |1
        is obsolete|                            |




--- Comment #3 from B. Green <brg at chromium.org>  2009-09-23 01:14:03 PDT ---
Created an attachment (id=39979)
 --> (https://bugs.webkit.org/attachment.cgi?id=39979)
Proposed implementation of window.Navigator.registerProtocolHandler

In reply to Mike Rowes' review:

>Why does Chrome::runJavaScriptRegisterProtocolHandler return a boolean?
It does not need to.  I had thought this would be a proper place for the UA to
return information to webkit, however it is better removed.

>This code won't even compile.
Fixed.  Attempted migration from another enlistment by typing, and then sanity
built without the flag defined.  My apologies.

>NAVIGATOR_ABILITIES is an incredibly vague name for a define and
>doesn't sound at all related to the function in question
Fixed by renaming the define to ENABLE_REGISTER_PROTOCOL_HANDLER.  The original
name was from a grouping used in the HTML5 spec for this and related APIs.

>It's not clear to me why this is #if'd at all given that the default behavior is to do nothing.
The API simply passes information to the UA.  This is done by adding the
runJavaScriptRegisterProtocolHandler pure virtual function to the ChromeClient
interface defined in WebCore/page/ChromeClient.h.  If it is not defined in the
codebase of the UA using webkit, compilation will break.  If it is dynamically
linked, then a runtime failure will occur.  As with the introduction of
Workers, perhaps it is better to leave it behind the ENABLE_ flag for a while?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.