[Webkit-unassigned] [Bug 29307] commit-queue needs web-based status reporting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29307


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39952|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #8 from David Levin <levin at chromium.org>  2009-09-22 16:21:11 PDT ---
(From update of attachment 39952)
Just a few nits to fix on landing.


> diff --git a/WebKitTools/CommitQueueStatus/filters/webkit_extras.py b/WebKitTools/CommitQueueStatus/filters/webkit_extras.py
> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.

> +bug_regexp = re.compile("bug (?P<bug_id>\d+)")

Put r in front of the quotes. (Fortunately \d doesn't map to a string escape
but best to put use r"" for this anyway.)

> +patch_regexp = re.compile("patch (?P<patch_id>\d+)")

Put r in front of the quotes.

> +
> + at stringfilter
> +def webkit_linkify(value):
> +    value = bug_regexp.sub('<a href="http://webkit.org/b/\g<bug_id>">bug \g<bug_id></a>', value)

Put r in front of the single quote (to make to clear that the \g isn't a string
escape).

> +    value = patch_regexp.sub('<a href="https://bugs.webkit.org/attachment.cgi?id=\g<patch_id>&action=prettypatch">patch \g<patch_id></a>', value)

Put r in front of the single quote.


> diff --git a/WebKitTools/CommitQueueStatus/queue_status.py b/WebKitTools/CommitQueueStatus/queue_status.py
> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.


> diff --git a/WebKitTools/Scripts/modules/statusbot.py b/WebKitTools/Scripts/modules/statusbot.py

> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.