[Webkit-unassigned] [Bug 29529] MathML Support for mover, munder, munderover, msubsup, and mfrac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 13:14:16 PDT 2009


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
  Attachment #39890|review?                     |review-
               Flag|                            |

--- Comment #4 from Dave Hyatt <hyatt at apple.com>  2009-09-22 13:14:15 PDT ---
(From update of attachment 39890)
Don't indent class headers.  I sent mail out to webkit-dev about this and
apologize for the style guide being wrong.

The code in RenderMathInlineContainer::setStyle is wrong.  You have lost any
non-inherited properties with the way you're doing that.   Typically when a
style needs to be adjusted we do this over in CSSStyleSelector's
adjustRenderStyle method.  I think SVG does some adjustments in its own adjust
method, so you may just want to do that over there.

You shouldn't have to set padding to 0 in makeBlockStyle.  Its default value is
0, and padding isn't inherited by default.  Same with margins.  The line-height
thing really confuses me. By forcing the line-height to be exactly the font's
height, you're not using the line-height that was built in to the font itself. 
Is that really what you want?

Similar questions in RenderMathSuperSub regarding why padding/margins are being
cleared out.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list