[Webkit-unassigned] [Bug 29140] getResponseHeader returns "" instead of null as the spec requires.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29140


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39698|review?                     |review-
               Flag|                            |




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2009-09-22 12:50:42 PDT ---
(From update of attachment 39698)
> -    if (!isValidToken(name))
> -        return "";
<...>
> +    //if name is not a "Valid token" it shall not match any valid header name thus the check for isValidToken is not needed.
> +    //since httpHeaderField(name) returns a null string anyway.
>      return m_response.httpHeaderField(name);

It seems fine to remove the check - I think that we should suggest removing
this clause form XMLHttpRequest spec, too.

I do not think that the comment is helpful - it talks about code that used to
be there, but isn't any more. Also, sentences should start with capital
letters, and there should be a space after "//". I suggest just removing the
comment, and e-mailing W3C WebApps working group about changing the spec.

> +        * http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Removed.
> +          getResponseHeader.html now covers this case as well.

You should remove expected results for this test, as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.