[Webkit-unassigned] [Bug 26342] Absolutely positioned HTML element within foreignObject of absolutely positioned SVG crashes Safari

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 11:13:34 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26342


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39844|review?                     |review+
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2009-09-22 11:13:32 PDT ---
(From update of attachment 39844)
> +    virtual bool isSVGForeignObject() const { return true; }

A function like this should be made private. If someone already has a
RenderForeignObject* it's a programming mistake for them to call
isSVGForeignObject and making it private will solve that problem.

Otherwise seems OK to make this change. I'll say r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list