[Webkit-unassigned] [Bug 28886] Build error using JIT with gcc 4.1.2 and ARM v5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28886





--- Comment #27 from Andre Pedralho <apedralho at gmail.com>  2009-09-22 08:37:46 PDT ---
(In reply to comment #24)
> Created an attachment (id=39925)
 --> (https://bugs.webkit.org/attachment.cgi?id=39925) [details]
> Avoid __clear_cache built-in function if NO_CLEAR_CACHE define is set
> 
> This patch adds an additional check for __clear_cache. If NO_CLEAR_CACHE is set
> the execution will skip __clear_cache case.
> 
> I have also fixed a silly typo in the inline assembly.

As I told you in #qtwebkit: we are fixing the issue disabling the feature,
aren't we? I know it is a very specific case (ARM and GCC 4.1.2).

Couldn't we do something using CLEAR_INSN_CACHE (as we don't have it defined)?
BTW, does anybody have it defined?

- #elif PLATFORM(ARM) && COMPILER(GCC) && (GCC_VERSION >= 30406)
+ #elif PLATFORM(ARM) && COMPILER(GCC) && (GCC_VERSION >= 30406) &&
defined(CLEAR_INSN_CACHE)   
     static void cacheFlush(void* code, size_t size)
     {   
         __clear_cache(reinterpret_cast<char*>(code),
reinterpret_cast<char*>(code) + size);
     }
- #elif PLATFORM(ARM_TRADITIONAL) && PLATFORM(LINUX)
+ #elif PLATFORM(ARM_TRADITIONAL) && PLATFORM(LINUX) ||
!defined(CLEAR_INSN_CACHE)
     static void cacheFlush(void* code, size_t size)
     {   
         asm volatile (
             "push    {r7}\n"
             "mov     r0, %0\n"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.