[Webkit-unassigned] [Bug 29100] svn-apply can't handle single-line binary file additions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 21 16:53:13 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29100
--- Comment #14 from Eric Seidel <eric at webkit.org> 2009-09-21 16:53:13 PDT ---
(In reply to comment #12)
> Actually, I'm not confident in these regexp changes. I'm not sure I like the
> design of guessing based on content. Assuming we're entering this path only
> for binary patch fragments, then this is OK, otherwise we'd match adding a file
> with just "me" as a base64 file.
Looks like we only enter this for patch fragments marked as binary, so this
should be OK.
if ($isBinary) {
# Binary change
handleBinaryChange($fullPath, $patch);
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list