[Webkit-unassigned] [Bug 29250] Add nspluginwrapper plugins dir

Mon Sep 21 13:28:39 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29250

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39818|review?                     |review-
               Flag|                            |

--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-09-21 13:28:39 PDT ---
(From update of attachment 39818)
Your ChangeLog has tabs.  That will fail to land due to our pre-commit hook
which looks for tabs.  Yes, we definitely should warn about this earlier than
during review.  (bug 29509).

Otherwise it looks sane enough to me.  I'll CC the linux chromium folks that
they might give more than just a rubber stamp (As they actually know something
about plugins on linux and I don't). :)

r- for the ChangeLog problem.  I would have r+'d this and you could fix it on
landing if you were a committer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.