[Webkit-unassigned] [Bug 29507] Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 13:16:00 PDT 2009


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #39788|review?                     |review-
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-09-21 13:16:00 PDT ---
(From update of attachment 39788)
Seems like a lot of headers to include for such a simple .cpp file.  I don't
know if fastMalloc/fastFree will behave as you want them to or not.  But I'm
happy to r+ a patch with them in it as, you'll figure out very quickly if
they're broken. ;)

releaseStack ignores the "size" argument.  Most of WebCore builds with -Wunused
enabled, if symbian ever turns that warning back on, this will break.

I'm not sure why Apple's copyright is copied into this tiny file.

I think normally we have an extra line after the corresponding header include,
in this case, I would expect a new line after 
+#include "MarkStack.h"

r- for the above mentioned nits.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list