[Webkit-unassigned] [Bug 29193] [chromium] Prevent JavaScript busy-loops in unload handlers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29193





--- Comment #34 from Peter Kasting <pkasting at google.com>  2009-09-21 13:12:41 PDT ---
(In reply to comment #33)
> > +v8::Handle<v8::FunctionTemplate> DateExtension::GetNativeFunction(v8::Handle<v8::String> name)
> > +{
> > +    if (name->Equals(v8::String::New("GiveEnableSleepDetectionFunction"))) {
> > +        return v8::FunctionTemplate::New(GiveEnableSleepDetectionFunction);
> > +    } else if (name->Equals(v8::String::New("OnSleepDetected"))) {
> > +        return v8::FunctionTemplate::New(OnSleepDetected);
> > +    }
> 
> nit: WebKit style is to not use {}'s around single line statements

Further nit: Not mentioned in WebKit's style guide, but sometimes advocated by
them, and also advocated by Google (I think), is to avoid "else" after
"return".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.