[Webkit-unassigned] [Bug 29605] New: [Chromium] Fix the V8 bindings' handling of window.top

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29605

           Summary: [Chromium] Fix the V8 bindings' handling of window.top
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: japhet at chromium.org
                CC: levin at chromium.org


I introduced a regression in the V8 bindings in
http://trac.webkit.org/changeset/47130/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm.
 We were special casing window.top, since we have disallowing shadowing on it,
but it's also marked as replaceable.  
I believe the solution is:
1. Add back in the special case handling to ensure window.top is not
v8::ReadOnly, as this causes a TypeError rather than silently failing.
2. Add in a FIXME to see if we can stop disallowing shadowing at some point in
the future.
3. Remove V8ReadOnly from window.top, since in any case other than this that
uses Replaceable, V8ReadOnly is redundant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.