[Webkit-unassigned] [Bug 29031] [v8] speed up access to windows impl from various methods

Mon Sep 21 08:53:59 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29031

anton muhin <antonm at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39853|                            |review?
               Flag|                            |
  Attachment #39184|0                           |1
        is obsolete|                            |

--- Comment #7 from anton muhin <antonm at chromium.org>  2009-09-21 08:53:57 PDT ---
Created an attachment (id=39853)
 --> (https://bugs.webkit.org/attachment.cgi?id=39853)
Second iteration

Another pass.  It passes newly added layout tests.

The major difference is lookupDOMWrapper is restored in accessors checks.  I
believe the reason is not security, but some technical details (if you're
curious: the way v8 is implemented it installs security callback on global
object proxy and I don't want to put pointers to window impl on it).  I'll
address those issues with a separate CL.

IMPORTANT NOTE (sorry for the case): please, do not land this patch: if it
passes a review, I'd have to add a helper method to public V8 API (to lookup
real named property).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.