[Webkit-unassigned] [Bug 29535] New: [Qt] Buildfix on Windows building with MSVC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29535

           Summary: [Qt] Buildfix on Windows building with MSVC
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Blocker
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: oszi at inf.u-szeged.hu


The error message:
..\..\..\JavaScriptCore\wtf/Vector.h(276) : warning C4003: not enough actual
parameters for macro 'max'
t:\webkit_git\javascriptcore\wtf\HashTraits.h(72) : warning C4003: not enough
actual parameters for macro 'max'
t:\webkit_git\javascriptcore\wtf\HashTraits.h(73) : warning C4003: not enough
actual parameters for macro 'max'
t:\webkit_git\javascriptcore\wtf\HashTraits.h(74) : warning C4003: not enough
actual parameters for macro 'max'
..\..\..\JavaScriptCore\runtime/UString.h(93) : warning C4003: not enough
actual parameters for macro 'max'
..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2589: '(' : illegal
token on right side of '::'
..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2059: syntax error :
'::'
..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2143: syntax error :
missing ';' before '{'
..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : warning C4003: not
enough actual parameters for macro 'max'
..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : error C2589: '(' :
illegal token on right side of '::'
..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : error C2059: syntax
error : '::'
..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(61) : error C2143: syntax
error : missing ';' before '{' QNetworkReplyHandler.cpp

Build error caused by define max(a,b) in a standard windows header (WinDef.h).
Here max function must be used instead of max macro, accordingly max macro
shouldn't be defined here. ( std::numeric_limits<T>::max() , ... )

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.