[Webkit-unassigned] [Bug 29292] [HTML5][Forms] Support for <textarea maxlength=N>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29292


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39807|                            |review?, commit-queue?
               Flag|                            |
  Attachment #39781|0                           |1
        is obsolete|                            |
  Attachment #39781|review?, commit-queue?      |
               Flag|                            |




--- Comment #12 from TAMURA, Kent <tkent at chromium.org>  2009-09-18 17:53:38 PDT ---
Created an attachment (id=39807)
 --> (https://bugs.webkit.org/attachment.cgi?id=39807)
Proposed patch (rev.5)

> Suppose that the string is "ab". numCharactersInGraphemeClusters(1) should
> return 1, not 2. If we specify length(), the result would be 2.

ok, I changed it to:

unsigned String::numCharactersInGraphemeClusters(unsigned numGraphemeClusters)
const
{
    TextBreakIterator* it = characterBreakIterator(characters(), length());
    if (!it)
        return min(length(), numGraphemeClusters);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.