[Webkit-unassigned] [Bug 29206] post-diff and post-commits should be able to find bug urls in ChangeLogs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29206


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39662|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-18 15:54:26 PDT ---
(From update of attachment 39662)
> +         - Fallback to bug urls in commit diffs, instead of just in commit messages,
> +           meaning post-commits will now find bug urls in ChangeLogs.

If this is for svn support, then it's fine.  Otherwise, I'd rather enforce
using the ChangeLog entries for commit logs.

> @@ -459,11 +459,17 @@ class ObsoleteAttachmentsOnBug(Command):
>  class PostDiffAsPatchToBug(Command):
>      def __init__(self):
>          options = [
> +            make_option("-m", "--description", action="store", type="string", dest="description", help="Description string for the attachment (default: 'patch')"),
> +        ]
> +        options += self.posting_options()
> +        Command.__init__(self, 'Attaches the current working directory diff to a bug as a patch file.', '[BUGID]', options=options)
> +
> +    @staticmethod
> +    def posting_options():
> +        return [
>              make_option("--no-obsolete", action="store_false", dest="obsolete_patches", default=True, help="Do not obsolete old patches before posting this one."),
>              make_option("--no-review", action="store_false", dest="review", default=True, help="Do not mark the patch for review."),
> -            make_option("-m", "--description", action="store", type="string", dest="description", help="Description string for the attachment (default: 'patch')"),
>          ]
> -        Command.__init__(self, 'Attaches the current working directory diff to a bug as a patch file.', 'BUGID', options=options)

Why is the -m|--description option listed separately?  It's also included
separately in PostCommitsAsPatchesToBug, so it should be included with
posting_options().

> +            # Perfer --bug-id=, then a bug url in the commit message, then a bug url in the entire commit diff (i.e. ChangeLogs).

Typo: "Perfer" should be "Prefer".

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.