[Webkit-unassigned] [Bug 29502] basic inputs layout test for chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 15:17:17 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29502


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39797|review?                     |review-
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-09-18 15:17:17 PDT ---
(From update of attachment 39797)
Now you have an extra space at the top of your ChangeLog file. :(

You might find http://webkit.org/coding/contributing.html#changelogs of
interest if you haven't already seen it.

Otherwise this looks fine.  I would r+ this, except you're not a committer so
it has to be perfect for the commit bot to land this for you. :(

While we're at it, "For chomium" is not a sentence, I assume you added an extra
period by mistake:
This tests all types of inputs text and password, both enabled and disabled,
the existing tests weren't thorough enough. For chromium.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list