[Webkit-unassigned] [Bug 29502] basic inputs layout test for chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 14:56:29 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29502


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39790|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-09-18 14:56:28 PDT ---
(From update of attachment 39790)
This also has tabs in the ChangeLog, which will make it impossible to land
automatically. :(

Missing a couple capital letters at the start of your sentences.

prepare-ChangeLog (the ChangeLog template generation tool) takes a --bug
argument which automatically inserts the bug url in the expected format in case
you need it in the future.  Generally the URL goes on its own line.

So asside from the ChagneLog nits, this looks fine.  but r- for the tabs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list