[Webkit-unassigned] [Bug 29092] Performance slow when loading a large text html file on Symbian platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29092


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39646|review?(ariya.hidayat at troll |review-
               Flag|tech.com)                   |




--- Comment #11 from Alexey Proskuryakov <ap at webkit.org>  2009-09-18 14:19:25 PDT ---
(From update of attachment 39646)
+        Optimize the code so only the text from start to end is scaned.

Typo: should be "scanned".

+    if(end < dataLength) {

Please add a space after "if".

+        TextBreakIterator* it = characterBreakIterator(data.characters() +
start, end - start + 1);

How will this behave if a non-BMP character is coming next (one that takes two
UTF-16 values)? Depending on the platform implementation of the iterator, it
may not work well.

Seems that this needs at least "+ 2". I think that it would work then, but I'm
also not 100% sure.

>     // If we have maxChars of unbreakable characters the above could lead to
>     // an infinite loop.

This comment needs to be updated, now that we rely on the code below in more
cases.

What exactly gave the performance boost for Qt, trimming from the beginning, or
from the end? If the latter is not necessary, I suggest passing the entire
remainder of the text to iterator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.