[Webkit-unassigned] [Bug 29218] Write transactions should start with a BEGIN IMMEDIATE command
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 18 13:50:07 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29218
Eric Seidel <eric at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #39730|review? |review+, commit-queue-
Flag| |
--- Comment #7 from Eric Seidel <eric at webkit.org> 2009-09-18 13:50:06 PDT ---
(From update of attachment 39730)
OK. I guess 2 more things I would have done if posting this patch to make the
reviewer's job a nobrainer would be:
1. link to the SQLLite docs about this in the ChangeLog (assuming a direct
link to the section could be found).
2. I would consider adding a comment next to:
+ if (m_readOnly)
+ m_inProgress = m_db.executeCommand("BEGIN;");
+ else
+ m_inProgress = m_db.executeCommand("BEGIN IMMEDIATE;");
to explain why we use BEGIN vs. BEGIN IMMEDIATE and what they do. Possibly
also referencing the SQLLite docs url if you feel that's necessary.
So r+, but I would like you to make modifications like described above when
landing. Or if you aren't a committer yet (I can never remember) and want this
commit-queue'd, then please post a new patch to be marked r+/cq+.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list