[Webkit-unassigned] [Bug 29292] [HTML5][Forms] Support for <textarea maxlength=N>
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 18 13:06:49 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29292
TAMURA, Kent <tkent at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #39781| |review?, commit-queue?
Flag| |
Attachment #39769|0 |1
is obsolete| |
--- Comment #10 from TAMURA, Kent <tkent at chromium.org> 2009-09-18 13:06:48 PDT ---
Created an attachment (id=39781)
--> (https://bugs.webkit.org/attachment.cgi?id=39781)
Proposed patch (rev.4)
> > + unsigned maxLength = static_cast<unsigned>(data.maxLength()); // maxLength() never be negative.
> Coding style says one space before the "//".
Fixed.
> The grammar here is wrong. It could be "can never be negative" or "never is
> negative" instead.
Fixed.
> > + unsigned appendableLength = maxLength > baseLength ? maxLength - baseLength : 0;
> Extra space here after the equal sign.
Fixed.
> > + TextBreakIterator* it = characterBreakIterator(characters(), length());
> The value length() is not right here. It should be min(length(),
> numGraphemeClusters) instead.
I don't think so.
Suppose that the string is "\ud800\udc00", of which length() is 2 and has 1
grapheme. numCharactersInGraphmeClusters(1) with this string should return 2.
If we specified min(length(), nmGraphemeClusters) to characerBreakIterator(),
the result would be 1.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list