[Webkit-unassigned] [Bug 29332] REGRESSION (r48446): While a <select> popup menu is open, the rest of the WebView doesn't respond to mouse move events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29332





--- Comment #6 from Anders Carlsson <andersca at apple.com>  2009-09-18 12:46:42 PDT ---
(In reply to comment #3)
> (From update of attachment 39778 [details])
> > +static void translatePoint(LPARAM& lParam, HWND from, HWND to) {
> 
> Please put the brace in a second line.
> 

Whoops, fixed.

> > +    // Protect the popup menu in case its owner is destroyed while we're running the message pump.
> > +    RefPtr<PopupMenu> protect(this);
> 
> I hate "protect" -- if there's any other way to make the lifetime work I would
> prefer it. It's so hard to know when you need to protect something -- once we
> add one of these it becomes voodoo code you can never remove. But it's better
> than explicit ref/deref, that's for sure.
> 

I couldn't think of a way to do this without having to redesign a lot of the
popup menu API.

> Did you mean to land this?
> 

Nope, I blame bugzilla-tool...

> Did you mean to land this?
> 

Nope, same here.

> I'm going to say review- because of those example changes, but it's really
> close to a review+

OK, I'll upload a new patch. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.